[Bug 749690] splitfilesrc: Implement binary search in find_part_for_offset

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749690

--- Comment #3 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Jan Schmidt from comment #2)
> Review of attachment 303773 [details] [review]:
> 
> ::: gst/multifile/gstsplitfilesrc.c
> @@ +374,3 @@
> +{
> +  if (part->start > *offset && part->stop < *offset)
> +    return -1;
> 
> offset can't be both <= start and >= stop for a file part.
> 
> The match function should look like:
> 
> if (*offset > part->stop)
>   return -1; /* The target is after this part */
> if (*offset < part->start)
>   return 1; /* The target is before this part */
> return 0; /* This is the target part */

Thanks for your review. I'll update new patch to include your comment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.