[Bug 749690] splitfilesrc: Implement binary search in find_part_for_offset

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749690

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303829|none                        |needs-work
             status|                            |

--- Comment #5 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 303829:
 --> (https://bugzilla.gnome.org/review?bug=749690&attachment=303829)

Thanks for the patch - still needs one minor fix I missed the first time.

::: gst/multifile/gstsplitfilesrc.c
@@ +390,3 @@
+  part =
+      gst_util_array_binary_search (src->parts, src->num_parts,
+      sizeof (GstFilePart),

Sorry - I missed this on the first review. The size of the array elements is
one pointer, not an entire GstFilePart - so it should be 'sizeof (GstFilePart 
*)' not 'sizeof (GstFilePart)'.

I imagine this would crash fairly badly - have you tested it at all?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.