[Bug 749328] hlsdemux: Simplify logic in process_manifest
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon May 25 05:47:44 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=749328
Thiago Sousa Santos <thiagossantos at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |thiagossantos at gmail.com
Resolution|FIXED |---
--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
This has broken unit tests for hlsdemux. Some unit tests rely on trying ti get
the variant with bitrate=0 to get the lowest one.
>From the function's name 'gst_m3u8_client_get_playlist_for_bitrate', having 0
meaning that it should return the current variant doesn't seem very clear. I'd
recommend reverting the patch and trying a different alternative. As that code
is not repeated in other parts, maybe it would make sense just to remove the
original FIXME comment.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list