[Bug 748738] gstevent: add new api for parse seek event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=748738

--- Comment #6 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Tim-Philipp Müller from comment #5)
> Comment on attachment 303392 [details] [review]
> gstevent: add new api for parse seek event
> 
> >diff --git a/gst/gstsegment.h b/gst/gstsegment.h
> >index f0f7af5..0ca84fd 100644
> >--- a/gst/gstsegment.h
> >+++ b/gst/gstsegment.h
> >@@ -202,6 +202,8 @@ struct _GstSegment {
> > 
> >   guint64         position;
> >   guint64         duration;
> >+  GstSeekType     start_type;
> >+  GstSeekType     stop_type;
> > 
> >   /* < private > */
> >   gpointer        _gst_reserved[GST_PADDING];
> 
> This breaks ABI, you need to make a struct with the two new fields and make
> that struct a union with the _gst_reserved field in order to make sure the
> overall struct size of GstSegment stays the same. I'm sure you can find
> examples if you grep for 'union' in the header files.

I appreciate your review. I make a struct with two new fileds using union.
I have found 'union' in the gstpad header file. thanks for your comment:)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.