[Bug 749536] rtspsrc: handle gap in tcp mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749536

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nicola from comment #5)
> reverting this patch
> 
> http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/
> ?id=87c8c163a876f45024a817e17af6dfdc52e71257
> 
> seems to restore the 1.4 behaviour

Obviously :P That's the change that introduces this error.


The problem is that without this change, the calculations later will run into
overflows/underflows and calculate things with GST_CLOCK_TIME_NONE. Just
reverting this is not going to help much, other than hiding the problem for the
cases where the wrong calculations don't hurt... and causing hard to debug
problems otherwise (like completely wrong timestamps without an error
anywhere).


The real fix for this would be to somehow get the capture time of the RTP
packet after the gap, which we currently can't for TCP (we only set a timestamp
on the very first packet).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.