[Bug 749328] hlsdemux: Simplify logic in process_manifest

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon May 25 08:32:13 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=749328

--- Comment #5 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Thiago Sousa Santos from comment #4)
> This has broken unit tests for hlsdemux. Some unit tests rely on trying ti
> get the variant with bitrate=0 to get the lowest one.
> 
> From the function's name 'gst_m3u8_client_get_playlist_for_bitrate', having
> 0 meaning that it should return the current variant doesn't seem very clear.
> I'd recommend reverting the patch and trying a different alternative. As
> that code is not repeated in other parts, maybe it would make sense just to
> remove the original FIXME comment.
Thanks for your comment. I agree your opinion. Also, I'm sorry about that I
didn't test that code.:( Actually I didn't know where is hls test code. So, I
heard from slomo where is that test code. I'll try a different alternative.
Actually I just test below command when I test the hlsdemux.

gst-launch souphttpsrc
location=http://devimages.apple.com/iphone/samples/bipbop/gear4/prog_index.m3u8
! hlsdemux ! decodebin2 ! videoconvert ! videoscale ! autovideosink

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list