[Bug 749846] gloverlay crash on missing file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749846

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303937|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 303937:
 --> (https://bugzilla.gnome.org/review?bug=749846&attachment=303937)

::: ext/gl/gstgloverlay.c
@@ +633,3 @@
   fp = fopen (overlay->location, "rb");
   if (!fp) {
+    LOAD_ERROR ("couldn't open file");

Sending a generic error is not nice. We have GST_RESOURCE_ERROR_NOT_FOUND for
that. Also, this should result in GST_FLOW_ERROR being returned to stop the
streaming thread.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.