[Bug 749846] gloverlay crash on missing file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749846

--- Comment #8 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 303953:
 --> (https://bugzilla.gnome.org/review?bug=749846&attachment=303953)

Looks mostly good.

::: ext/gl/gstgloverlay.c
@@ +75,3 @@

+static gint gst_gl_overlay_load_png (GstGLFilter * filter, GError ** error);
+static gint gst_gl_overlay_load_jpeg (GstGLFilter * filter, GError ** error);

match these with the implementations below.

s/gint/gboolean/

@@ +594,3 @@
+          gst_element_post_message (GST_ELEMENT_CAST (filter), msg);
+          g_clear_error (&error);
+          g_free (debug);

GST_ELEMENT_ERROR macro as Nicolas mentioned

::: gst-libs/gst/gl/gstglfilter.c
@@ +922,3 @@
     gst_gl_sync_meta_set_sync_point (out_sync_meta, context);

+  return ret ? GST_FLOW_OK : GST_FLOW_ERROR;

separate this into a separate patch please

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.