[Bug 749909] New: matroska: overwritten value assignment

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749909

            Bug ID: 749909
           Summary: matroska: overwritten value assignment
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: luis at debethencourt.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 304018
  --> https://bugzilla.gnome.org/attachment.cgi?id=304018&action=edit
patch removing first assignment

The value curpos in gst/matroska/matroska-read-common.c:2419 is set to
gst_ebml_read_get_pos (ebml) and then immediately after set again to the same
value. The first assignment being overwritten with the same value.

  guint64 curpos;

  curpos = gst_ebml_read_get_pos (ebml);

  /* Make sure we don't parse a tags element twice and
   * post it's tags twice */
  curpos = gst_ebml_read_get_pos (ebml);


This looks like a simple dead assignment problem. But want to confirm here in
bugzilla since this code has been in gst-plugins-good since 2011, making me
wonder if there is something hidden I am missing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.