[Bug 749846] gloverlay crash on missing file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749846

--- Comment #9 from Xavier Claessens <xclaesse at gmail.com> ---
It's actually not that easy. I cannot use GST_ELEMENT_ERROR() in
gst_gl_overlay_load_png() because errors are not fatal there, we fallback to
try  gst_gl_overlay_load_jpeg(). So I have to use the common pattern of
returning FALSE with a GError. And GST_ELEMENT_ERROR() does not take a GError,
so posting it manually seems the best way...

I guess ideally gst_gl_overlay_filter_texture() should be responsibly of
opening the file, read the magic number in the header to determine if it's PNG
or JPEG, then pass the FILE* to gst_gl_overlay_load_png() or
gst_gl_overlay_load_jpeg(). In that case error in those function could use
GST_ELEMENT_ERROR().

But maybe that cleanup is work for another bug, if someone care.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.