[Bug 747881] rtpmp4gdepay does not calculate timestamp for RTP packets with multiple Access Units

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747881

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 301684
  --> https://bugzilla.gnome.org/attachment.cgi?id=301684
rtpmp4gdepay: fix timestamps for RTP packets with multiple AUs

>-          /* make sure we don't use the timestamp again for other AUs in this
>-           * RTP packet. */
>-          timestamp = -1;
>+          if (rtpmp4gdepay->constantDuration != 0 && i + 1 < num_AU_headers) {
>+            /* if we have constantDuration, calculate timestamp for next AU
>+             * in this RTP packet. */
>+            timestamp += (rtpmp4gdepay->constantDuration * GST_SECOND) /
>+                depayload->clock_rate;
>+          } else {
>+            /* otherwise, make sure we don't use the timestamp again for other
>+             * AUs. */
>+            timestamp = GST_CLOCK_TIME_NONE;
>+          }

Not sure this && i+1<num check is actually needed? Aren't we going to quit the
loop right after that anyway?

Otherwise it looks fine to me, and seems to work.

Wim?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.