[Bug 749535] downloadbuffer: deadlock issue in playbin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749535

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303659|none                        |needs-work
             status|                            |

--- Comment #6 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 303659:
 --> (https://bugzilla.gnome.org/review?bug=749535&attachment=303659)

Still some minor changes to fix.

Also, please limit lines in your commit messages to 80 chars for easier reading
in logs.

Thanks!

::: plugins/elements/gstdownloadbuffer.c
@@ -411,3 @@
-{
-  dlbuf->cur_level.bytes = bytes;
-  update_time_level (dlbuf);

update_time_level now also updates the byte level because of this change.
Please keep the 2 functions or rename the new update_time_level to
update_levels.

@@ +1068,3 @@
+
+            GST_DOWNLOAD_BUFFER_MUTEX_LOCK_CHECK (dlbuf, dlbuf->sinkresult,
+                out_flushing);

Here you are still taking the lock again after posting the message. Ideally you
only post the message further below in the code when the lock is released and
doesn't need to be retaken.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.