[Bug 749535] downloadbuffer: deadlock issue in playbin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749535

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Eunhae Choi from comment #7)
> I will make short commit message:) 

No need to make it short, just break it into multiple lines.

> 
> in the patch, I've renamed the update_time_level to update_levels. 
> as you know, there was two functions - update_time_level, update_levels.
> I merged it to one function - update_levels. This updates byte and time.

Ah, true. I didn't notice that you had changed the name already.

> 
> and to add signal I got lock again like before. do I need to remove the
> lock? 
> Thank you.

Not exactly. At this part you are only unlocking to post the message and then
you lock again. Instead you should only post the message after the unlock at
the end of the block (at the end of the 'GST_EVENT_IS_SERIALIZED' if). This way
you don't need to unlock and then lock again.

> 
> @@ +1068,3 @@
> +
> +            GST_DOWNLOAD_BUFFER_MUTEX_LOCK_CHECK (dlbuf, dlbuf->sinkresult,
> +                out_flushing);
> 
>             /* wakeup the waiter and let it recheck */
>             GST_DOWNLOAD_BUFFER_SIGNAL_ADD (dlbuf, -1);
>             break;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.