[Bug 750040] tests: add dynamic audiovisualizers example

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 28 08:46:50 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750040

--- Comment #2 from Luis de Bethencourt <luis at debethencourt.com> ---
To be honest I didn't knew of the existence of
gst-plugins-base/tests/icles/test-effect-switch. I based the audiovisualizer
switcher in the demo code in the documentation.

The only two differences are:
  - location: eventhough test-effect-switch is in -base some of the elements in
the default list are in -good and -bad. My proposal is in the same module where
the elements are.
  - audiovisualizers instead of video effects

It is really hard to justify code duplication with only those two differences. 

If an element in the default list isn't available, it won't be added to the
queue used in the automatic switching. Not a big problem.

For the second difference, audiovisualizers aren't really that complex to use
that they must have example code.

If you agree with this, I am inclined to close this as "Won't Fix" and not
merge the code.

In an unrelated topic, what is the reason for the divide between tests/examples
and test/icles in gst-plugins-base? This is mostly the reason I didn't knew of
this code's existence.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list