[Bug 749535] downloadbuffer: deadlock issue in playbin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749535

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304210|none                        |needs-work
             status|                            |

--- Comment #10 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 304210:
 --> (https://bugzilla.gnome.org/review?bug=749535&attachment=304210)

::: plugins/elements/gstdownloadbuffer.c
@@ +1064,3 @@
             /* wakeup the waiter and let it recheck */
             GST_DOWNLOAD_BUFFER_SIGNAL_ADD (dlbuf, -1);
+            GST_DOWNLOAD_BUFFER_MUTEX_UNLOCK (dlbuf);

This is not right as the same mutex will be unlocked again a few lines below
around line 1082. You need to post the message after that unlock.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.