[Bug 747557] zbar: Get an image along with the barcode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747557

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304280|none                        |reviewed
             status|                            |

--- Comment #8 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 304280
  --> https://bugzilla.gnome.org/attachment.cgi?id=304280
zbar: add frame sample to barcode message

Thanks, looks good! Two small nitpicks:

 - could you add "(Since 1.6)" in the property description and/or a gtk-doc
chunk for the property with a "Since: 1.6"?

 - create the structure with the common fields and then do:

     if (zbar->frame_attach)
       gst_structure_set (s, frame", GST_TYPE_SAMPLE, sample, NULL);

Feel free to push then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.