[Bug 750039] Keeping buffers with shared memory alive

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750039

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
I'm looked through this, and gst_buffer_append_region() is really the only way
to reach this situation. It's the only case we can add a GstMemory to a buffer
without taking the exclusive lock.

I think I understand that idea, but the gstbuffer.c is incomplete. It should
take the lock if the received GstBuffer isn't writable (e.g. you took a ref to
keep the second buffer). Otherwise not taking this lock is unsafe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.