[Bug 749856] d3dvideosink: avoid frame rendering while window handle is hidden

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749856

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #303949|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 303949:
 --> (https://bugzilla.gnome.org/review?bug=749856&attachment=303949)

Thanks for the patch, looks really good and useful :) Just some minor style
comments, other than that this can be merged

::: sys/d3dvideosink/d3dhelpers.c
@@ +1824,3 @@
+#define IWVTU_PARTIAL 2
+#define IWVTU_HIDDEN  3
+#define IWVTU_ERROR   4

Why IWVTU, and why not an enum? What about calling it e.g.
WINDOW_VISIBILITY_FULL, _PARTIAL, etc?

@@ +1833,3 @@
+  HDC hdcWnd;
+  RECT rcWndClient;
+  RECT rcWndClip;

We generally use lowercase variable names, with underscores to split words

@@ +1873,3 @@
+           uRetVal = IWVTU_FULL;
+        else
+           uRetVal = IWVTU_PARTIAL;

I guess with a simple region we could also only render part of the frame
relatively efficient? But not really important for a first step :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.