[Bug 750027] concat: Reset internal start offset to 0 after flushing seek

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750027

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304152|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 304152:
 --> (https://bugzilla.gnome.org/review?bug=750027&attachment=304152)

::: plugins/elements/gstconcat.c
@@ +523,3 @@
+            "resetting start offset to 0 after flushing seek");
+        self->current_start_offset = 0;
+        self->reset_ofs_after_flushseek = FALSE;

I think resetting the base time makes sense *always* (not only after seeks)
when we forward flush events. The sink will have its segment reset, so base
starts from 0 again.

@@ +593,3 @@
+          GST_DEBUG_OBJECT (self,
+              "flushing seek detected; will reset start offset after flush");
+          self->reset_ofs_after_flushseek = TRUE;

To reliably match a flush event to the seek event you'll have to compare the
sequence numbers

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.