[Bug 749653] dashdemux: Implement binary search for stream_sidx_seek

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat May 30 02:58:48 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=749653

--- Comment #12 from Jimmy Ohn <yongjin.ohn at lge.com> ---
(In reply to Reynaldo H. Verdejo Pinochet from comment #11)
> Comment on attachment 303756 [details] [review]
> replace binary search to optimize in stream_sidx_seek.
> 
> 
> > 
> >+static gint
> >+gst_dash_demux_index_entry_search (GstSidxBoxEntry * entry, GstClockTime * ts,
> >+    gpointer user_data)
> >+{
> >+  if (entry->pts + entry->duration < *ts)
> >+    return -1;
> >+  else if (entry->pts + entry->duration > *ts)
> >+    return 1;
> >+  else
> >+    return 0;
> >+}
> 
> It might make sense to avoid computing entry->pts + entry->duration
> twice.

Thanks for your comment. I upload new patch to avoid computing it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list