[Bug 750189] Some improvements to gstchildproxy.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750189

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304329|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304329:
 --> (https://bugzilla.gnome.org/review?bug=750189&attachment=304329)

This looks correct to me. See comment on the ABI.

::: gst/gstchildproxy.h
@@ +64,3 @@
   GObject * (*get_child_by_index) (GstChildProxy * parent, guint index);
   guint     (*get_children_count) (GstChildProxy * parent);
+  gchar   * (*get_child_name)     (GstChildProxy * parent, GObject *child);

That's an ABI break. You need to reduce the padding. Fortunately you have added
a pointer and the padding array is of type gpointer. So that would do:

  gpointer _gst_reserved[GST_PADDING - 1];

Normally, running "make distcheck" should run the ABI check, hence catch this
kind of error.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.