[Bug 750189] gstchildproxy: some improvements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750189

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #304330|none                        |needs-work
             status|                            |

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 304330:
 --> (https://bugzilla.gnome.org/review?bug=750189&attachment=304330)

You need to update windows definition to. Looks like useful feature.

::: gst/gstchildproxy.c
@@ +113,3 @@
+  guint count, i;
+  GObject *object;
+  gchar *object_name = gst_object_get_name (GST_OBJECT (proxy));

A bit unrelated, but the proxy have to be a GstObject ?

@@ +337,3 @@
+ * objects that implement the given property.
+ *
+ * MT safe.

This will requires a Since 1.6 mark

::: gst/gstchildproxy.h
@@ +84,3 @@
                                               GObject **target, GParamSpec
**pspec);
+GList *
+gst_child_proxy_lookup_all (GstChildProxy * object, const gchar * name);

Style is different here, all other lines put that on same line.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.