[Bug 750189] gstchildproxy: some improvements

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750189

--- Comment #10 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #6)
> Review of attachment 304330 [details] [review]:
> 
> You need to update windows definition to. Looks like useful feature.
> 
> ::: gst/gstchildproxy.c
> @@ +113,3 @@
> +  guint count, i;
> +  GObject *object;
> +  gchar *object_name = gst_object_get_name (GST_OBJECT (proxy));
> 
> A bit unrelated, but the proxy have to be a GstObject ?
> 

Indeed it doesn't have to, I have renamed the get_child_name to get_object_name
and use it to get the name of the proxy too.

> @@ +337,3 @@
> + * objects that implement the given property.
> + *
> + * MT safe.
> 
> This will requires a Since 1.6 mark
> 
Done
> ::: gst/gstchildproxy.h
> @@ +84,3 @@
>                                                GObject **target, GParamSpec
> **pspec);
> +GList *
> +gst_child_proxy_lookup_all (GstChildProxy * object, const gchar * name);
> 
> Style is different here, all other lines put that on same line.

Done

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.