[Bug 755319] configure: add --with-hls-crypto=auto|nettle|libgcrypt|openssl option

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=755319

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #314861|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 314861:
 --> (https://bugzilla.gnome.org/review?bug=755319&attachment=314861)

::: configure.ac
@@ +3042,3 @@
+    which cryptographic library version to compile against for hls (default:
auto)
+  ]),
+    [case "$with_hls_crypto" in

You could use AS_CASE here too

@@ +3060,3 @@
+    [nettle], [
+      AC_DEFINE(HAVE_NETTLE, 1, [Define if nettle is available])
+      HAVE_HLS="yes"

Each of these cases should also check for the actual availability of the
corresponding library, and if it does not exist error out.

I don't see a way either to not have the checks twice (here and then again for
the auto case), so let's just go with that for now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.