[gst-cvs] gstreamer: gsttaglist: Remove unused variable.

Edward Hervey bilboed at kemper.freedesktop.org
Sat Apr 4 05:44:14 PDT 2009


Module: gstreamer
Branch: master
Commit: a69841761b07cf010a474e1540a25189a3f13a78
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=a69841761b07cf010a474e1540a25189a3f13a78

Author: Edward Hervey <bilboed at bilboed.com>
Date:   Sat Apr  4 14:37:13 2009 +0200

gsttaglist: Remove unused variable.

We don't need to allocate a variable if it's the return of a function call
and we only check it once.

---

 gst/gsttaglist.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/gst/gsttaglist.c b/gst/gsttaglist.c
index 78ff003..c8ae601 100644
--- a/gst/gsttaglist.c
+++ b/gst/gsttaglist.c
@@ -873,7 +873,6 @@ void
 gst_tag_list_add_valist_values (GstTagList * list, GstTagMergeMode mode,
     const gchar * tag, va_list var_args)
 {
-  GstTagInfo *info;
   GQuark quark;
 
   g_return_if_fail (GST_IS_TAG_LIST (list));
@@ -886,8 +885,7 @@ gst_tag_list_add_valist_values (GstTagList * list, GstTagMergeMode mode,
 
   while (tag != NULL) {
     quark = g_quark_from_string (tag);
-    info = gst_tag_lookup (quark);
-    g_return_if_fail (info != NULL);
+    g_return_if_fail (gst_tag_lookup (quark) != NULL);
     gst_tag_list_add_value_internal (list, mode, quark, va_arg (var_args,
             GValue *));
     tag = va_arg (var_args, gchar *);





More information about the Gstreamer-commits mailing list