[gst-cvs] gst-plugins-bad: bz2: fix some refcount mistakes and do some cleaning up

Tim Mueller tpm at kemper.freedesktop.org
Sat Apr 4 11:04:16 PDT 2009


Module: gst-plugins-bad
Branch: master
Commit: 788fed202d51bd1632817af71928567d474f7e3e
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=788fed202d51bd1632817af71928567d474f7e3e

Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sat Apr  4 17:51:34 2009 +0100

bz2: fix some refcount mistakes and do some cleaning up

No need to unref buffers if pad_push returns something non-FLOW_OK.
In fact, this will cause assertions or crashes. However, we do need
to unref the input buffer whenever we don't pass it downstream. Also,
a non-OK flow return is not an error, so don't post error messages on
the bus - the pipeline may just be shutting down. Miscellaneous other
clean-ups and crack removal. Plenty of work left for those who feel
like it.

---

 ext/bz2/Makefile.am |    2 +-
 ext/bz2/gstbz2dec.c |  102 ++++++++++++++++++++-------------
 ext/bz2/gstbz2enc.c |  157 +++++++++++++++++++++++++++++++-------------------
 3 files changed, 159 insertions(+), 102 deletions(-)

Diff:   http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/diff/?id=788fed202d51bd1632817af71928567d474f7e3e




More information about the Gstreamer-commits mailing list