[gst-cvs] gst-plugins-good: jpegdec: fix warning for still images by not trying to divide by 0

Tim Mueller tpm at kemper.freedesktop.org
Mon Apr 20 11:44:46 PDT 2009


Module: gst-plugins-good
Branch: master
Commit: 8d8e9af0a89cff894f7ee8e6fc8b83fe3f39562f
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=8d8e9af0a89cff894f7ee8e6fc8b83fe3f39562f

Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Mon Apr 20 19:32:00 2009 +0100

jpegdec: fix warning for still images by not trying to divide by 0

Don't pass a 0 divisor to gst_util_uint64_scale(), or it will complain
in the single image case where fps=0/1 (are we supposed to differentiate
between no fps=still image and fps=0/1=variable rate here btw?)

---

 ext/jpeg/gstjpegdec.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ext/jpeg/gstjpegdec.c b/ext/jpeg/gstjpegdec.c
index 2c68397..a0391cc 100644
--- a/ext/jpeg/gstjpegdec.c
+++ b/ext/jpeg/gstjpegdec.c
@@ -985,7 +985,7 @@ gst_jpeg_dec_chain (GstPad * pad, GstBuffer * buf)
 
     /* calculate or assume an average frame duration for QoS purposes */
     GST_OBJECT_LOCK (dec);
-    if (dec->framerate_denominator != 0) {
+    if (dec->framerate_numerator != 0) {
       dec->qos_duration = gst_util_uint64_scale (GST_SECOND,
           dec->framerate_denominator, dec->framerate_numerator);
     } else {





More information about the Gstreamer-commits mailing list