[gst-cvs] gstreamer: gstbuffer: add additional checking for writability

[Wim Taymans]

Module: gstreamer
Branch: master
Commit: aa33db85ccc9ecebc458030e9bb2bf7b2d77da1c
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=aa33db85ccc9ecebc458030e9bb2bf7b2d77da1c

Author: Wim Taymans <wim.taymans at collabora.co.uk>
Date:   Thu Aug  6 18:47:32 2009 +0200

gstbuffer: add additional checking for writability

Check for metadata writability when setting caps on buffer or when copying
metadata flags. Only enable these extra assertions in git versions.
This should help us find bad elements.

---

 gst/gstbuffer.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/gst/gstbuffer.c b/gst/gstbuffer.c
index 9919211..b56b16c 100644
--- a/gst/gstbuffer.c
+++ b/gst/gstbuffer.c
@@ -197,6 +197,11 @@ gst_buffer_copy_metadata (GstBuffer * dest, const GstBuffer * src,
   if (G_UNLIKELY (dest == src))
     return;
 
+#if GST_VERSION_NANO == 1
+  /* we enable this extra debugging in git versions only for now */
+  g_return_if_fail (gst_buffer_is_metadata_writable (dest));
+#endif
+
   GST_CAT_LOG (GST_CAT_BUFFER, "copy %p to %p", src, dest);
 
   if (flags & GST_BUFFER_COPY_FLAGS) {
@@ -395,6 +400,10 @@ void
 gst_buffer_set_caps (GstBuffer * buffer, GstCaps * caps)
 {
   g_return_if_fail (buffer != NULL);
+#if GST_VERSION_NANO == 1
+  /* we enable this extra debugging in git versions only for now */
+  g_return_if_fail (gst_buffer_is_metadata_writable (buffer));
+#endif
 
   gst_caps_replace (&GST_BUFFER_CAPS (buffer), caps);
 }