[gst-cvs] gst-plugins-base: theoradec: fix buffer overrun on 422 decode.

Michael Smith msmith at kemper.freedesktop.org
Sun May 10 18:09:06 PDT 2009


Module: gst-plugins-base
Branch: master
Commit: 21c52af2b388d3132e92dd6b536751cecc88a6c6
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=21c52af2b388d3132e92dd6b536751cecc88a6c6

Author: Michael Smith <msmith at syncword.(none)>
Date:   Mon Apr 27 22:42:55 2009 -0700

theoradec: fix buffer overrun on 422 decode.

---

 ext/theora/theoradec.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/theora/theoradec.c b/ext/theora/theoradec.c
index 7494139..bd89b2a 100644
--- a/ext/theora/theoradec.c
+++ b/ext/theora/theoradec.c
@@ -1219,7 +1219,7 @@ theora_handle_422_image (GstTheoraDec * dec, yuv_buffer * yuv, GstBuffer ** out)
 
       curdest = dest + 1;
       src = src_cb;
-      for (j = 0; j < width; j++) {
+      for (j = 0; j < width / 2; j++) {
         *curdest = *src++;
         curdest += 4;
       }
@@ -1227,7 +1227,7 @@ theora_handle_422_image (GstTheoraDec * dec, yuv_buffer * yuv, GstBuffer ** out)
 
       curdest = dest + 3;
       src = src_cr;
-      for (j = 0; j < width; j++) {
+      for (j = 0; j < width / 2; j++) {
         *curdest = *src++;
         curdest += 4;
       }





More information about the Gstreamer-commits mailing list