[gst-cvs] gstreamer: Revert "element: Set the originating pad as message source in gst_element_found_tags_for_pad ()"

Sebastian Dröge slomo at kemper.freedesktop.org
Wed May 27 05:33:42 PDT 2009


Module: gstreamer
Branch: master
Commit: db6f445620c98df8568ec421ce422f9bb5206324
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=db6f445620c98df8568ec421ce422f9bb5206324

Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Wed May 27 14:06:13 2009 +0200

Revert "element: Set the originating pad as message source in gst_element_found_tags_for_pad ()"

This reverts commit bebfde75027e975b7e7c74c6358c5be83ea4ac9f.

This change shouldn't be done in a stable release series as
applications are actually expecting the sender to be an
GstElement. One example is totem.

---

 gst/gstutils.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/gst/gstutils.c b/gst/gstutils.c
index 3b5c4de..602822c 100644
--- a/gst/gstutils.c
+++ b/gst/gstutils.c
@@ -3081,9 +3081,11 @@ gst_element_found_tags_for_pad (GstElement * element,
   g_return_if_fail (list != NULL);
 
   gst_pad_push_event (pad, gst_event_new_tag (gst_tag_list_copy (list)));
-
+  /* FIXME 0.11: Set the pad as source to make it possible to detect for
+   * which pad the tags are actually found.
+   */
   gst_element_post_message (element,
-      gst_message_new_tag (GST_OBJECT (pad), list));
+      gst_message_new_tag (GST_OBJECT (element), list));
 }
 
 static void





More information about the Gstreamer-commits mailing list