[gst-cvs] gst-plugins-base: gnomevfssrc: fixes warnings in macosx

[Josep Torra]

Hi Stefan,

Sorry I messed on commit, I did the change as you asked in IRC but
commited it with wrong message, I've got confused as I was reverting the
 audioconvert commit that changed common.

In summary [1] says audioconvert and should be gnomevfs and have the
proper fix you requested me.

Is it possible fix the commit message ?

[1]
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=a34c29b52401b2895ccf5f35ba97fb38ef430202


Stefan Kost wrote:
> Hi,
> 
> Josep Torra schrieb:
>> Module: gst-plugins-base
>> Branch: master
>> Commit: c272d8d9fb10bb0f7b7e8fe5fe7debc45addae81
>> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=c272d8d9fb10bb0f7b7e8fe5fe7debc45addae81
>>
>> Author: Josep Torra <n770galaxy at gmail.com>
>> Date:   Fri Oct  9 14:28:42 2009 +0200
>>
>> gnomevfssrc: fixes warnings in macosx
>>
>> warning: format '%llu' expects type 'long long unsigned int', but argument 8 has type 'GnomeVFSFileOffset'
>> warning: format '%lld' expects type 'long long int', but argument 9 has type 'guint64'
>>
>> ---
>>
>>  ext/gnomevfs/gstgnomevfssrc.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ext/gnomevfs/gstgnomevfssrc.c b/ext/gnomevfs/gstgnomevfssrc.c
>> index 6494545..9941208 100644
>> --- a/ext/gnomevfs/gstgnomevfssrc.c
>> +++ b/ext/gnomevfs/gstgnomevfssrc.c
>> @@ -609,8 +609,8 @@ gst_gnome_vfs_src_create (GstBaseSrc * basesrc, guint64 offset, guint size,
>>  
>>    src = GST_GNOME_VFS_SRC (basesrc);
>>  
>> -  GST_DEBUG ("now at %llu, reading from %lld, size %u", src->curoffset, offset,
>> -      size);
>> +  GST_DEBUG ("now at %" G_GUINT64_FORMAT ", reading from %" G_GUINT64_FORMAT
>> +      ", size %u", (guint64) src->curoffset, offset, size);
> 
> can you please do these a bit more carefully. As I told you on IRC already
> src->curoffset is a GnomeVFSFileOffset and this is defined as
> G_GNUC_EXTENSION typedef gint64 GnomeVFSFileOffset;
> 
> So please use G_GINT64_FORMAT instead and don't cast. If you need to cast then
> recast to the expected type, that is gint64 and not guint64 here.
> 
> Thanks,
> 
> Stefan
> 
>>  
>>    /* seek if required */
>>    if (G_UNLIKELY (src->curoffset != offset)) {
>>
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay 
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> gstreamer-cvs mailing list
>> gstreamer-cvs at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs
> 
> 
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay 
> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
> http://p.sf.net/sfu/devconference
> _______________________________________________
> gstreamer-cvs mailing list
> gstreamer-cvs at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs