[gst-cvs] gst-plugins-good: cacasink: exit properly when invalid driver has been selected.

[Tim Mueller]

Module: gst-plugins-good
Branch: master
Commit: 45042dffbc14bdb43d95ddcb72da14d85f2adc1b
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=45042dffbc14bdb43d95ddcb72da14d85f2adc1b

Author: Priit Laes <plaes at plaes.org>
Date:   Mon Oct 19 21:59:23 2009 +0300

cacasink: exit properly when invalid driver has been selected.

See #599018.

---

 ext/libcaca/gstcacasink.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/ext/libcaca/gstcacasink.c b/ext/libcaca/gstcacasink.c
index 07bd47e..8102fff 100644
--- a/ext/libcaca/gstcacasink.c
+++ b/ext/libcaca/gstcacasink.c
@@ -350,7 +350,12 @@ static gboolean
 gst_cacasink_open (GstCACASink * cacasink)
 {
   cacasink->bitmap = NULL;
-  caca_init ();
+
+  if (caca_init () < 0) {
+    GST_ELEMENT_ERROR (cacasink, RESOURCE, OPEN_WRITE, (NULL),
+        ("caca_init() failed"));
+    return FALSE;
+  }
 
   cacasink->screen_width = caca_get_width ();
   cacasink->screen_height = caca_get_height ();