[gst-cvs] gst-plugins-base: alsa: don' t pass non-constant strings as printf format strings

Tim Müller tpm at kemper.freedesktop.org
Wed Apr 7 17:30:24 PDT 2010


Module: gst-plugins-base
Branch: master
Commit: 930f72c6b0e021aa8621534d4e7dfcd448a5b627
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=930f72c6b0e021aa8621534d4e7dfcd448a5b627

Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Thu Apr  8 01:26:09 2010 +0100

alsa: don't pass non-constant strings as printf format strings

Fixes 'format not a string literal and no format arguments' compiler
warning when compiling with -DGST_DISABLE_PRINTF_EXTENSION.

---

 ext/alsa/gstalsasink.c |    3 ++-
 ext/alsa/gstalsasrc.c  |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/ext/alsa/gstalsasink.c b/ext/alsa/gstalsasink.c
index b1ef741..72ad68f 100644
--- a/ext/alsa/gstalsasink.c
+++ b/ext/alsa/gstalsasink.c
@@ -476,7 +476,8 @@ no_channels:
           g_strdup_printf (_
           ("Could not open device for playback in %d-channel mode."),
           alsa->channels);
-    GST_ELEMENT_ERROR (alsa, RESOURCE, SETTINGS, (msg), (snd_strerror (err)));
+    GST_ELEMENT_ERROR (alsa, RESOURCE, SETTINGS, ("%s", msg),
+        ("%s", snd_strerror (err)));
     g_free (msg);
     snd_pcm_hw_params_free (params);
     return err;
diff --git a/ext/alsa/gstalsasrc.c b/ext/alsa/gstalsasrc.c
index 4789771..f061a1c 100644
--- a/ext/alsa/gstalsasrc.c
+++ b/ext/alsa/gstalsasrc.c
@@ -413,7 +413,8 @@ no_channels:
           g_strdup_printf (_
           ("Could not open device for recording in %d-channel mode"),
           alsa->channels);
-    GST_ELEMENT_ERROR (alsa, RESOURCE, SETTINGS, (msg), (snd_strerror (err)));
+    GST_ELEMENT_ERROR (alsa, RESOURCE, SETTINGS, ("%s", msg),
+        ("%s", snd_strerror (err)));
     g_free (msg);
     snd_pcm_hw_params_free (params);
     return err;





More information about the Gstreamer-commits mailing list