[gst-cvs] gst-plugins-bad: check: Don't re-declare 'GList *buffers' in the tests

Edward Hervey bilboed at kemper.freedesktop.org
Mon Apr 12 09:11:56 PDT 2010


Module: gst-plugins-bad
Branch: master
Commit: 14482a65809516c4a517f208c8cc23ee570263e6
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=14482a65809516c4a517f208c8cc23ee570263e6

Author: Edward Hervey <bilboed at bilboed.com>
Date:   Mon Apr 12 18:07:29 2010 +0200

check: Don't re-declare 'GList *buffers' in the tests

It's an external which lives in gstcheck.c. Redeclaring it makes some
compilers/architectures think the 'buffers' in the individual tests are
a different symbol... and therefore we end up comparing holodecks with
oranges.

---

 tests/check/elements/aacparse.c |    1 -
 tests/check/elements/amrparse.c |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/tests/check/elements/aacparse.c b/tests/check/elements/aacparse.c
index 78662a2..d29e18c 100644
--- a/tests/check/elements/aacparse.c
+++ b/tests/check/elements/aacparse.c
@@ -37,7 +37,6 @@
     "audio/mpeg, framed=(boolean)true, mpegversion=4, rate=96000, channels=2"
 #define SINK_CAPS_TMPL  "audio/mpeg, framed=(boolean)true, mpegversion=(int){2,4}"
 
-GList *buffers;
 GList *current_buf = NULL;
 
 GstPad *srcpad, *sinkpad;
diff --git a/tests/check/elements/amrparse.c b/tests/check/elements/amrparse.c
index 4c6457d..2c0a2bb 100644
--- a/tests/check/elements/amrparse.c
+++ b/tests/check/elements/amrparse.c
@@ -36,7 +36,6 @@
 
 #define AMR_FRAME_DURATION (GST_SECOND/50)
 
-GList *buffers;
 GList *current_buf = NULL;
 
 GstPad *srcpad, *sinkpad;





More information about the Gstreamer-commits mailing list