[gst-cvs] gst-plugins-base: playsink: Correctly reconfigure the video chain when switching from a subtitle to a non-subtitle file

Sebastian Dröge slomo at kemper.freedesktop.org
Thu Apr 29 10:06:51 PDT 2010


Module: gst-plugins-base
Branch: master
Commit: 6c9ead703004c4a7a135e027aeba309949d89cb1
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=6c9ead703004c4a7a135e027aeba309949d89cb1

Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
Date:   Fri Apr 23 16:24:11 2010 +0200

playsink: Correctly reconfigure the video chain when switching from a subtitle to a non-subtitle file

Fixes bug #616422.

---

 gst/playback/gstplaysink.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gst/playback/gstplaysink.c b/gst/playback/gstplaysink.c
index ebbecfc..ebd6f88 100644
--- a/gst/playback/gstplaysink.c
+++ b/gst/playback/gstplaysink.c
@@ -1915,7 +1915,8 @@ gst_play_sink_reconfigure (GstPlaySink * playsink)
       add_chain (GST_PLAY_CHAIN (playsink->videochain), TRUE);
       activate_chain (GST_PLAY_CHAIN (playsink->videochain), TRUE);
       /* if we are not part of vis or subtitles, set the ghostpad target */
-      if (!need_vis && !need_text && !playsink->textchain) {
+      if (!need_vis && !need_text && (!playsink->textchain
+              || !playsink->text_pad)) {
         GST_DEBUG_OBJECT (playsink, "ghosting video sinkpad");
         gst_ghost_pad_set_target (GST_GHOST_PAD_CAST (playsink->video_pad),
             playsink->videochain->sinkpad);





More information about the Gstreamer-commits mailing list