[gst-cvs] gst-plugins-good: qtdemux: prevent reading past avc1 atom when parsing

[Mark Nauwelaerts]

Module: gst-plugins-good
Branch: master
Commit: 8ea04c66b8826737824a7bb9cd5979921f238acc
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=8ea04c66b8826737824a7bb9cd5979921f238acc

Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Wed Aug 11 11:17:18 2010 +0200

qtdemux: prevent reading past avc1 atom when parsing

... when one of the subatoms has a large/invalid size.

Fixes #626609.

---

 gst/qtdemux/qtdemux.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gst/qtdemux/qtdemux.c b/gst/qtdemux/qtdemux.c
index bfe68b0..ce1e5ab 100644
--- a/gst/qtdemux/qtdemux.c
+++ b/gst/qtdemux/qtdemux.c
@@ -5435,8 +5435,8 @@ qtdemux_parse_trak (GstQTDemux * qtdemux, GNode * trak)
                 break;
             }
 
-            len -= QT_UINT32 (avc_data);
-            avc_data += QT_UINT32 (avc_data);
+            len -= size + 8;
+            avc_data += size + 8;
           }
 
           break;