[gst-cvs] gst-plugins-base: xvimagesink: It' s not a bad thing if the preferred video format needs less bytes per frame

[Jan Schmidt]

I think you mis-read the logic of the check you removed. It does the
opposite of your comment - it prevents the bufferalloc from returning a
buffer that is *smaller* than upstream requires.

- J.

On Wed, 2010-08-11 at 09:11 -0700, Sebastian Dröge wrote: 
> Module: gst-plugins-base
> Branch: master
> Commit: 2a08bcc53f223d1092e3520b67c33c40532db813
> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=2a08bcc53f223d1092e3520b67c33c40532db813
> 
> Author: Sebastian Dröge <sebastian.droege at collabora.co.uk>
> Date:   Wed Aug 11 17:00:54 2010 +0200
> 
> xvimagesink: It's not a bad thing if the preferred video format needs less bytes per frame
> 
> ---
> 
>  sys/xvimage/xvimagesink.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/sys/xvimage/xvimagesink.c b/sys/xvimage/xvimagesink.c
> index b26dd3e..f1a1528 100644
> --- a/sys/xvimage/xvimagesink.c
> +++ b/sys/xvimage/xvimagesink.c
> @@ -2588,13 +2588,6 @@ reuse_last_caps:
>      /* We found no suitable image in the pool. Creating... */
>      GST_DEBUG_OBJECT (xvimagesink, "no usable image in pool, creating xvimage");
>      xvimage = gst_xvimagesink_xvimage_new (xvimagesink, intersection);
> -    if (xvimage && xvimage->size < size) {
> -      /* This image is unusable. Destroying... */
> -      GST_LOG_OBJECT (xvimagesink, "Discarding allocated buffer as unsuitable. "
> -          "Falling back to normal buffer");
> -      gst_xvimage_buffer_free (xvimage);
> -      xvimage = NULL;
> -    }
>    }
>    g_mutex_unlock (xvimagesink->pool_lock);
>  
> 
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by 
> 
> Make an app they can't live without
> Enter the BlackBerry Developer Challenge
> http://p.sf.net/sfu/RIM-dev2dev 
> _______________________________________________ gstreamer-cvs mailing list gstreamer-cvs at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gstreamer-cvs

-- 
Jan Schmidt <thaytan at noraisin.net>