[gst-cvs] gst-plugins-good: jpegenc: add a fixme for handling other YUV variants

Stefan Kost ensonic at kemper.freedesktop.org
Tue Feb 16 00:24:58 PST 2010


Module: gst-plugins-good
Branch: master
Commit: 45522aab4691501ad9db7828ad539111375679ac
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=45522aab4691501ad9db7828ad539111375679ac

Author: Stefan Kost <ensonic at users.sf.net>
Date:   Tue Feb 16 10:10:45 2010 +0200

jpegenc: add a fixme for handling other YUV variants

---

 ext/jpeg/gstjpegenc.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/ext/jpeg/gstjpegenc.c b/ext/jpeg/gstjpegenc.c
index 73e674c..01f1665 100644
--- a/ext/jpeg/gstjpegenc.c
+++ b/ext/jpeg/gstjpegenc.c
@@ -514,6 +514,11 @@ gst_jpegenc_chain (GstPad * pad, GstBuffer * buf)
   end[1] = base[1] + (height / 2) * I420_U_ROWSTRIDE (width);
   end[2] = base[2] + (height / 2) * I420_V_ROWSTRIDE (width);
 
+  /* FIXME: shouldn't we also set
+   * - jpegenc->cinfo.max_{v,h}_samp_factor
+   * - jpegenc->cinfo.comp_info[0,1,2].{v,h}_samp_factor
+   * accordingly?
+   */
   jpegenc->jdest.next_output_byte = GST_BUFFER_DATA (jpegenc->output_buffer);
   jpegenc->jdest.free_in_buffer = GST_BUFFER_SIZE (jpegenc->output_buffer);
 





More information about the Gstreamer-commits mailing list