[gst-cvs] gst-plugins-ugly: rtspreal: fix minor memory leak

Tim Mueller tpm at kemper.freedesktop.org
Sat Jan 30 11:50:48 PST 2010


Module: gst-plugins-ugly
Branch: master
Commit: 4cb5f323080a493d6a102afe9cb7700eee3410a3
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-ugly/commit/?id=4cb5f323080a493d6a102afe9cb7700eee3410a3

Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sat Jan 30 19:10:45 2010 +0000

rtspreal: fix minor memory leak

Caps take their own reference when a buffer is added to them, so
unref buffer after adding it to caps (#608533).

---

 gst/realmedia/rtspreal.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gst/realmedia/rtspreal.c b/gst/realmedia/rtspreal.c
index 81d75bb..1c07030 100644
--- a/gst/realmedia/rtspreal.c
+++ b/gst/realmedia/rtspreal.c
@@ -593,7 +593,9 @@ rtsp_ext_real_parse_sdp (GstRTSPExtension * ext, GstSDPMessage * sdp,
   GST_BUFFER_SIZE (buf) = offset;
 
   /* Set on caps */
+  GST_BUFFER_FLAG_SET (buf, GST_BUFFER_FLAG_IN_CAPS);
   gst_structure_set (props, "config", GST_TYPE_BUFFER, buf, NULL);
+  gst_buffer_unref (buf);
 
   /* Overwrite encoding and media fields */
   gst_structure_set (props, "encoding-name", G_TYPE_STRING, "X-REAL-RDT", NULL);





More information about the Gstreamer-commits mailing list