[gst-cvs] gstreamer: basesink: add accessors for the enable-last-buffer property.

Tim-Philipp Müller t.i.m at zen.co.uk
Tue Jul 6 12:01:40 PDT 2010


On Tue, 2010-07-06 at 21:38 +0300, Stefan Kost wrote:

> this misses
> g_object_notify(sink, "enable-last-buffer");
> if its called directly. It would need a static helper call from g_object_set and
> the public setter, where the public setter calls g_object_notify().

I don't think we do this *anywhere* in GStreamer for any property
changed by a direct accessor function, apart from maybe
gst_pad_set_caps() and one or two other functions.

Maybe we should, who knows. No one seems to have had any need for it so
far.

> Shouldn't we start to do this properly?

I doubt gstreamer-cvs is the best place to discuss this..

 Cheers
  -Tim





More information about the Gstreamer-commits mailing list