[gst-cvs] gst-plugins-bad: dccp: Remove dead assignments

Edward Hervey bilboed at kemper.freedesktop.org
Thu Nov 25 10:40:58 PST 2010


Module: gst-plugins-bad
Branch: master
Commit: 7905c19e4eb7984297ef11e04e44fa215787cd68
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=7905c19e4eb7984297ef11e04e44fa215787cd68

Author: Edward Hervey <bilboed at bilboed.com>
Date:   Thu Nov 25 19:01:42 2010 +0100

dccp: Remove dead assignments

---

 gst/dccp/gstdccp.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/gst/dccp/gstdccp.c b/gst/dccp/gstdccp.c
index 40ddac5..470c217 100644
--- a/gst/dccp/gstdccp.c
+++ b/gst/dccp/gstdccp.c
@@ -90,7 +90,6 @@ gst_dccp_read_buffer (GstElement * this, int socket, GstBuffer ** buf)
 {
   fd_set testfds;
   int maxfdp1;
-  int ret;
   gssize bytes_read;
 #ifndef G_OS_WIN32
   int readsize;
@@ -108,7 +107,7 @@ gst_dccp_read_buffer (GstElement * this, int socket, GstBuffer ** buf)
   maxfdp1 = socket + 1;
 
   /* no action (0) is also an error in our case */
-  if ((ret = select (maxfdp1, &testfds, NULL, NULL, 0)) <= 0) {
+  if (select (maxfdp1, &testfds, NULL, NULL, 0) <= 0) {
     GST_ELEMENT_ERROR (this, RESOURCE, READ, (NULL),
         ("select failed: %s", g_strerror (errno)));
     return GST_FLOW_ERROR;
@@ -116,11 +115,11 @@ gst_dccp_read_buffer (GstElement * this, int socket, GstBuffer ** buf)
 
   /* ask how much is available for reading on the socket */
 #ifndef G_OS_WIN32
-  if ((ret = ioctl (socket, FIONREAD, &readsize)) < 0) {
+  if (ioctl (socket, FIONREAD, &readsize) < 0) {
     GST_ELEMENT_ERROR (this, RESOURCE, READ, (NULL),
         ("read FIONREAD value failed: %s", g_strerror (errno)));
 #else
-  if ((ret = ioctlsocket (socket, FIONREAD, &readsize)) == SOCKET_ERROR) {
+  if (ioctlsocket (socket, FIONREAD, &readsize) == SOCKET_ERROR) {
     GST_ELEMENT_ERROR (this, RESOURCE, READ, (NULL),
         ("read FIONREAD value failed: %s", g_strerror (WSAGetLastError ())));
 #endif





More information about the Gstreamer-commits mailing list