[gst-cvs] gst-plugins-bad: valve: no need to ref the object in _chain

Stefan Kost ensonic at kemper.freedesktop.org
Sat Oct 2 08:27:05 PDT 2010


Module: gst-plugins-bad
Branch: master
Commit: 7ae63847a8c3455338c155448a309623d74cdf22
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=7ae63847a8c3455338c155448a309623d74cdf22

Author: Stefan Kost <ensonic at users.sf.net>
Date:   Tue Sep 28 13:52:29 2010 +0300

valve: no need to ref the object in _chain

Don't ref the pad in chain, like elsewhere

---

 gst/valve/gstvalve.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/gst/valve/gstvalve.c b/gst/valve/gstvalve.c
index 4192074..977a4af 100644
--- a/gst/valve/gstvalve.c
+++ b/gst/valve/gstvalve.c
@@ -180,7 +180,7 @@ gst_valve_get_property (GObject * object,
 static GstFlowReturn
 gst_valve_chain (GstPad * pad, GstBuffer * buffer)
 {
-  GstValve *valve = GST_VALVE (gst_pad_get_parent_element (pad));
+  GstValve *valve = GST_VALVE (GST_OBJECT_PARENT (pad));
   GstFlowReturn ret = GST_FLOW_OK;
 
   if (g_atomic_int_get (&valve->drop)) {
@@ -202,8 +202,6 @@ gst_valve_chain (GstPad * pad, GstBuffer * buffer)
   if (g_atomic_int_get (&valve->drop))
     ret = GST_FLOW_OK;
 
-  gst_object_unref (valve);
-
   return ret;
 }
 





More information about the Gstreamer-commits mailing list