[gst-cvs] gstreamer: elementfactory: make sure gstreamer has been initialized when creating elements
Tim Müller
tpm at kemper.freedesktop.org
Thu Sep 16 11:43:57 PDT 2010
Module: gstreamer
Branch: master
Commit: 80ddde400a6ad66f44ccbbbaacde2ab8c93ee792
URL: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=80ddde400a6ad66f44ccbbbaacde2ab8c93ee792
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date: Thu Sep 16 19:27:57 2010 +0100
elementfactory: make sure gstreamer has been initialized when creating elements
Add gst_is_initialized() guard to gst_element_factory_make(), so
people who forgot to call gst_init() get a useful warning for what
seems to be a common enough mistake.
---
gst/gstelementfactory.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/gst/gstelementfactory.c b/gst/gstelementfactory.c
index bef3f1b..903e812 100644
--- a/gst/gstelementfactory.c
+++ b/gst/gstelementfactory.c
@@ -64,6 +64,7 @@
#include "gstinfo.h"
#include "gsturi.h"
#include "gstregistry.h"
+#include "gst.h"
#include "glib-compat-private.h"
@@ -435,6 +436,7 @@ gst_element_factory_make (const gchar * factoryname, const gchar * name)
GstElement *element;
g_return_val_if_fail (factoryname != NULL, NULL);
+ g_return_val_if_fail (gst_is_initialized (), NULL);
GST_LOG ("gstelementfactory: make \"%s\" \"%s\"",
factoryname, GST_STR_NULL (name));
More information about the Gstreamer-commits
mailing list