[gst-cvs] gst-plugins-base: tags: when converting freeform strings try Windows-1252 as fallback instead of ISO-8859-1

Tim Müller tpm at kemper.freedesktop.org
Tue Sep 28 02:36:38 PDT 2010


Module: gst-plugins-base
Branch: master
Commit: b3e39daee08ac079eb43d849e3c96e4588a8f977
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=b3e39daee08ac079eb43d849e3c96e4588a8f977

Author: Sreerenj Balachandran <sreerenj.balachandran at nokia.com>
Date:   Thu Sep 23 23:53:48 2010 +0300

tags: when converting freeform strings try Windows-1252 as fallback instead of ISO-8859-1

Windows-1252 is a superset of ISO-8859-1, which uses some space
allocated to control characters for additional printable characters.

https://bugzilla.gnome.org/show_bug.cgi?id=630471

---

 gst-libs/gst/tag/tags.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gst-libs/gst/tag/tags.c b/gst-libs/gst/tag/tags.c
index 1a9abcd..ebce1e2 100644
--- a/gst-libs/gst/tag/tags.c
+++ b/gst-libs/gst/tag/tags.c
@@ -442,9 +442,9 @@ gst_tag_freeform_string_to_utf8 (const gchar * data, gint size,
     }
   }
 
-  /* Try ISO-8859-1 */
-  GST_LOG ("Trying to convert freeform string using ISO-8859-1 fallback");
-  utf8 = g_convert (data, size, "UTF-8", "ISO-8859-1", &bytes_read, NULL, NULL);
+  /* Try Windows-1252 */
+  GST_LOG ("Trying to convert freeform string using Windows-1252 fallback");
+  utf8 = g_convert (data, size, "UTF-8", "Windows-1252", &bytes_read, NULL, NULL);
   if (utf8 != NULL && bytes_read == size) {
     goto beach;
   }





More information about the Gstreamer-commits mailing list