[0.11] gst-plugins-good: monoscope: we have 64 colors, don't access colors[ 64]

Wim Taymans wtay at kemper.freedesktop.org
Fri Mar 4 07:32:36 PST 2011


Module: gst-plugins-good
Branch: 0.11
Commit: 7bc3344131a307a4da3b0f65c1d6ca6968226f6e
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=7bc3344131a307a4da3b0f65c1d6ca6968226f6e

Author: Stefan Kost <ensonic at users.sf.net>
Date:   Wed Mar  2 12:59:35 2011 +0200

monoscope: we have 64 colors, don't access colors[64]

Fixes remaining invalid read.

---

 gst/monoscope/monoscope.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gst/monoscope/monoscope.c b/gst/monoscope/monoscope.c
index b3fce24..e6e4346 100644
--- a/gst/monoscope/monoscope.c
+++ b/gst/monoscope/monoscope.c
@@ -119,8 +119,8 @@ monoscope_update (struct monoscope_state * stateptr, gint16 data[512])
     foo >>= 18;
     if (foo > 63)
       foo = 63;
-    if (foo < -64)
-      foo = -64;
+    if (foo < -63)
+      foo = -63;
     val = (i + ((foo + 64) << 8));
     bar = val;
     if ((bar > 0) && (bar < (256 * 128))) {



More information about the gstreamer-commits mailing list