[0.11] gst-plugins-good: monoscope: don't leak the monoscope_state data

Wim Taymans wtay at kemper.freedesktop.org
Fri Mar 4 07:32:36 PST 2011


Module: gst-plugins-good
Branch: 0.11
Commit: 3ec3bed497b488364726c87e522c05b846ed4e70
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=3ec3bed497b488364726c87e522c05b846ed4e70

Author: Stefan Kost <ensonic at users.sf.net>
Date:   Wed Mar  2 13:00:31 2011 +0200

monoscope: don't leak the monoscope_state data

The monoscope_close() implementation was empty.

---

 gst/monoscope/monoscope.c |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/gst/monoscope/monoscope.c b/gst/monoscope/monoscope.c
index e6e4346..98822d3 100644
--- a/gst/monoscope/monoscope.c
+++ b/gst/monoscope/monoscope.c
@@ -73,8 +73,15 @@ monoscope_init (guint32 resx, guint32 resy)
   return stateptr;
 }
 
+void
+monoscope_close (struct monoscope_state *stateptr)
+{
+  convolve_close (stateptr->cstate);
+  free (stateptr);
+}
+
 guint32 *
-monoscope_update (struct monoscope_state * stateptr, gint16 data[512])
+monoscope_update (struct monoscope_state *stateptr, gint16 data[512])
 {
   /* Note that CONVOLVE_BIG must == data size here, ie 512. */
   /* Really, we want samples evenly spread over the available data.
@@ -155,8 +162,3 @@ monoscope_update (struct monoscope_state * stateptr, gint16 data[512])
 
   return stateptr->display;
 }
-
-void
-monoscope_close (struct monoscope_state *stateptr)
-{
-}



More information about the gstreamer-commits mailing list