[0.11] gstreamer: miniobject: remove FIXME

Wim Taymans wtay at kemper.freedesktop.org
Fri Mar 4 09:12:25 PST 2011


Module: gstreamer
Branch: 0.11
Commit: dea2351539372c64be4612e2ecf19037773cd8a8
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=dea2351539372c64be4612e2ecf19037773cd8a8

Author: Wim Taymans <wim.taymans at collabora.co.uk>
Date:   Fri Mar  4 18:11:19 2011 +0100

miniobject: remove FIXME

Now that we don't subclass buffers anymore, the FIXME about limited
functionality of the copy function is irrelevant.

---

 gst/gstminiobject.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/gst/gstminiobject.c b/gst/gstminiobject.c
index 02784c6..907edb9 100644
--- a/gst/gstminiobject.c
+++ b/gst/gstminiobject.c
@@ -111,20 +111,6 @@ gst_mini_object_init (GstMiniObject * mini_object, GType type, gsize size)
   mini_object->size = size;
 }
 
-/* FIXME 0.11: Current way of doing the copy makes it impossible
- * to currectly chain to the parent classes and do a copy in a
- * subclass without knowing all internals of the parent classes.
- *
- * For 0.11 we should do something like the following:
- *  - The GstMiniObjectClass::copy() implementation of GstMiniObject
- *    should call g_type_create_instance() with the type of the source
- *    object.
- *  - All GstMiniObjectClass::copy() implementations should as first
- *    thing chain up to the parent class and then do whatever they need
- *    to do to copy their type specific data. Note that this way the
- *    instance_init() functions are called!
- */
-
 /**
  * gst_mini_object_copy:
  * @mini_object: the mini-object to copy



More information about the gstreamer-commits mailing list