gst-plugins-bad: camerabin2: No need to force audiosrc to null on stop_capture

Thiago Sousa Santos thiagoss at kemper.freedesktop.org
Wed Mar 23 13:16:27 PDT 2011


Module: gst-plugins-bad
Branch: master
Commit: 6913db30f89162012437eae6b41fbaa726fce200
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=6913db30f89162012437eae6b41fbaa726fce200

Author: Thiago Santos <thiago.sousa.santos at collabora.co.uk>
Date:   Tue Mar 22 12:04:20 2011 -0300

camerabin2: No need to force audiosrc to null on stop_capture

Setting the audio source to null isn't needed and it could
make the EOS that is still flowing be dropped if autoaudiosrc
is used because its pads go flushing before the EOS gets pushed
from the real source.

---

 gst/camerabin2/gstcamerabin2.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/gst/camerabin2/gstcamerabin2.c b/gst/camerabin2/gstcamerabin2.c
index 36aae08..38f093d 100644
--- a/gst/camerabin2/gstcamerabin2.c
+++ b/gst/camerabin2/gstcamerabin2.c
@@ -258,7 +258,6 @@ gst_camera_bin_stop_capture (GstCameraBin * camerabin)
 
   if (camerabin->mode == MODE_VIDEO && camerabin->audio_src) {
     gst_element_send_event (camerabin->audio_src, gst_event_new_eos ());
-    gst_element_set_state (camerabin->audio_src, GST_STATE_NULL);
   }
 }
 



More information about the gstreamer-commits mailing list