gstreamer: bytereader, bytewriter: fix up inline functions to make g++ happy
Tim Müller
tpm at kemper.freedesktop.org
Wed Mar 23 13:53:36 PDT 2011
Module: gstreamer
Branch: master
Commit: 5300a5e73b1c20958e3a348003e750d5be50930c
URL: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=5300a5e73b1c20958e3a348003e750d5be50930c
Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date: Sat Mar 12 16:58:01 2011 +0000
bytereader, bytewriter: fix up inline functions to make g++ happy
gstbytereader.h: In function âguint8* gst_byte_reader_dup_data_unchecked(GstByteReader*, guint)â:
gstbytereader.h:249:75: error: invalid conversion from âvoid*â to âguint8*â
gstbytewriter.h: In function âgboolean _gst_byte_writer_ensure_free_space_inline(GstByteWriter*, guint)â:
gstbytewriter.h:196:75: error: invalid conversion from âvoid*â to âguint8*â
https://bugzilla.gnome.org/show_bug.cgi?id=645595
---
libs/gst/base/gstbytereader.h | 3 ++-
libs/gst/base/gstbytewriter.h | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/libs/gst/base/gstbytereader.h b/libs/gst/base/gstbytereader.h
index f25c3b5..8ce76df 100644
--- a/libs/gst/base/gstbytereader.h
+++ b/libs/gst/base/gstbytereader.h
@@ -246,7 +246,8 @@ gst_byte_reader_get_data_unchecked (GstByteReader * reader, guint size)
static inline guint8 *
gst_byte_reader_dup_data_unchecked (GstByteReader * reader, guint size)
{
- return g_memdup (gst_byte_reader_get_data_unchecked (reader, size), size);
+ gconstpointer data = gst_byte_reader_get_data_unchecked (reader, size);
+ return (guint8 *) g_memdup (data, size);
}
/* Unchecked variants that should not be used */
diff --git a/libs/gst/base/gstbytewriter.h b/libs/gst/base/gstbytewriter.h
index 186480d..8fcd53d 100644
--- a/libs/gst/base/gstbytewriter.h
+++ b/libs/gst/base/gstbytewriter.h
@@ -183,7 +183,7 @@ _gst_byte_writer_next_pow2 (guint n)
static inline gboolean
_gst_byte_writer_ensure_free_space_inline (GstByteWriter * writer, guint size)
{
- guint8 *data;
+ gpointer data;
if (G_LIKELY (size <= writer->alloc_size - writer->parent.byte))
return TRUE;
@@ -197,7 +197,7 @@ _gst_byte_writer_ensure_free_space_inline (GstByteWriter * writer, guint size)
if (G_UNLIKELY (data == NULL))
return FALSE;
- writer->parent.data = data;
+ writer->parent.data = (guint8 *) data;
return TRUE;
}
More information about the gstreamer-commits
mailing list