gst-plugins-bad: dshow: fix list iteration code

Tim Müller tpm at kemper.freedesktop.org
Sun Mar 27 09:43:32 PDT 2011


Module: gst-plugins-bad
Branch: master
Commit: f09f27a761d793db7903040eabb10b429260cea5
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=f09f27a761d793db7903040eabb10b429260cea5

Author: Tim-Philipp Müller <tim.muller at collabora.co.uk>
Date:   Sun Mar 27 17:42:56 2011 +0100

dshow: fix list iteration code

---

 sys/dshowsrcwrapper/gstdshow.cpp |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/sys/dshowsrcwrapper/gstdshow.cpp b/sys/dshowsrcwrapper/gstdshow.cpp
index b2d577b..11ea159 100644
--- a/sys/dshowsrcwrapper/gstdshow.cpp
+++ b/sys/dshowsrcwrapper/gstdshow.cpp
@@ -123,13 +123,10 @@ gst_dshow_new_pin_mediatype_from_streamcaps (IPin * pin, gint id, IAMStreamConfi
 void
 gst_dshow_free_pins_mediatypes (GList * pins_mediatypes)
 {
-  guint i = 0;
-  for (; i < g_list_length (pins_mediatypes); i++) {
-    GList *mylist = g_list_nth (pins_mediatypes, i);
-    if (mylist && mylist->data)
-      gst_dshow_free_pin_mediatype ((GstCapturePinMediaType *) mylist->data);
+  while (pins_mediatypes != NULL) {
+    gst_dshow_free_pin_mediatype (pins_mediatypes->data);
+    pins_mediatypes = g_list_remove_link (pins_mediatypes, pins_mediatypes);
   }
-  g_list_free (pins_mediatypes);
 }
 
 gboolean



More information about the gstreamer-commits mailing list